Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHP-CSS-Parser to v8.5.0 #7721

Closed
westonruter opened this issue Feb 1, 2024 · 2 comments · Fixed by #7742
Closed

Update PHP-CSS-Parser to v8.5.0 #7721

westonruter opened this issue Feb 1, 2024 · 2 comments · Fixed by #7742
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one
Milestone
v2.5.3

Comments

@westonruter
Copy link
Member

Feature Description

There have finally been new releases of PHP-CSS-Parser. The most recent being v8.5.0. We're currently pinned to a commit on master:

amp-wp/composer.json

Line 20 in 716c418

"sabberworm/php-css-parser": "dev-master#cc791ad"

There haven't actually been many commits between where we pinned and the latest version: MyIntervals/PHP-CSS-Parser@cc791ad...8.5.0

Getting onto an actual version would be good so that dependabot can start updating it automatically.

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response
@westonruter westonruter added the Enhancement New feature or improvement of an existing one label Feb 1, 2024
@westonruter westonruter added this to the v2.5.3 milestone Feb 1, 2024
@swissspidy
Copy link
Collaborator

This would be a nice change, especially now since the master branch has been renamed. That means I can't do a simple composer update in the Web Stories repo anymore

@westonruter westonruter mentioned this issue Feb 15, 2024
Merged
2 tasks
@pavanpatil1
Copy link

QA Passed ✅

Verified it with themes such as Twenty Twenty-Four and Twenty Twenty-One, everything appears to be in order. No CSS breaking changes were observed.

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Mar 20, 2024
@github-project-automation github-project-automation bot moved this to QA Passed in Ongoing Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one
Projects
Ongoing
Archived in project
Milestone
v2.5.3
Development

Successfully merging a pull request may close this issue.

Bump PHP-CSS-Parser to v8.5.1 ampproject/amp-wp
3 participants
@westonruter @swissspidy @pavanpatil1