Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in Legacy Theme #7491

Closed
milindmore22 opened this issue Mar 20, 2023 · 2 comments · Fixed by #7492
Closed

Improvements in Legacy Theme #7491

milindmore22 opened this issue Mar 20, 2023 · 2 comments · Fixed by #7492
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Milestone

Comments

@milindmore22
Copy link
Collaborator

Bug Description

Best Practices

Serves images with low resolution

The gravatar is being served in low resolution 24X24 as per updated standards we should serve images with 36X36 resolutions
image

For this we can simply increase the image size to 36X36

Accessibility

Background and foreground colors do not have a sufficient contrast ratio.

According to the new WCGA Standard (2.2), AAA draft the contrast ratio should be 7:1 and the Current AA standards it's 4.5:1

image

As I checked the contrast ratio on this online tool, I can adjust the background color's contrast ratio to find the following colors that can meet requirements, I am proposing to update the default background colors as per following

WCGA Standard Contrast Ratio

Standard AA AAA
Ratio 4.5:1 7:1
Color #0A7DB3 #0A5F85
Status Published Drafted

Page Speed

Before
After

Expected Behaviour

Should pass an audit that we control using the AMP plugin to be passed as per updated standards.

Screenshots

No response

PHP Version

8.0

Plugin Version

2.4.0

AMP plugin template mode

Reader

WordPress Version

6.1.1

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

No response

Browser(s) Affected

No response

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@pavanpatil1
Copy link

QA Passed ✅

Verified the issue, The issues related to A11y and low-resolution images in the legacy theme are fixed.

Before:

image
before.pdf

After:
image

After.pdf

@milindmore22
Copy link
Collaborator Author

Looks good 👍🏼

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants