Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically mark GA4 scripts as being PX-verified #7289

Closed
westonruter opened this issue Oct 8, 2022 · 1 comment · Fixed by #7290
Closed

Automatically mark GA4 scripts as being PX-verified #7289

westonruter opened this issue Oct 8, 2022 · 1 comment · Fixed by #7290
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one
Milestone

Comments

@westonruter
Copy link
Member

westonruter commented Oct 8, 2022

Feature Description

As we have advised in the support forum, site owners can use GA4 on AMP pages by using the moderate sandboxing level and adding data-px-verified-tag to the Google Analytics scripts.

We should add a sanitizer that will do this automatically when the user has selected either the Moderate or Loose sandboxing level. This will facilitate using GA4 while waiting on an AMP implementation.

Acceptance Criteria

GA4 scripts should not get sanitized from pages when in Moderate or Loose sandboxing level.

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@westonruter westonruter added the Enhancement New feature or improvement of an existing one label Oct 8, 2022
@westonruter westonruter added this to the v2.3.1 milestone Oct 8, 2022
@westonruter westonruter modified the milestones: v2.3.1, v2.4 Jan 26, 2023
@pavanpatil1
Copy link

QA Passed ✅

Cross-checked the issue and the fix added for the issue is working as expected with the Moderate or Loose sandboxing mode.

  • Gtag script is displayed as data-px-verified.
  • Element with gtag on click script is also displayed as data-px-verified.

image

image

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants