-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Plugin Suppression section is scrolled into view when deep linked #7005
Comments
@pooja-muchandikar Can you please provide a specific Browser and it's the version where you were facing this issue? |
@dhaval-parekh Following are the details where issue was observed. AMP Mode: Standard Browser Details: Screen Resolutions Tested: NOTE: Redirections is working fine with above resolution in safari browser(v14 and v15) |
QA Passed ✅ With One Regression Issue. Chrome Version 102.0.5005.61, Also checked with Chrome Version 100.0.4896.60 -> Review Plugin Suppression is redirected/scrolled to proper section. But Found one regression issue(Browser Safari Version 14.0.3 and Safari 15.3) When the Review Plugin Suppression is scrolled to review section the menu from left sidebar scrolls upwards. Because of the UI is not looking good. Observe the sidebar in following screenshots. Chrome Browser Scroll: Safari Browser Scroll: |
That would seem like it is a bug in WordPress core and not something we should worry about. |
Bug Description
As noted by @pooja-muchandikar in #5340 (comment):
I think this is a separate issue with the Settings screen. Namely, I think the Review section is loaded asynchronously after the scrolling has started so that once the scrolling ends up the Review section and not Plugin Suppression.
Nevertheless, I am not able to reproduce the issue right now.
Expected Behaviour
The Plugin Suppression section should be scrolled into view when linking to
/wp-admin/admin.php?page=amp-options#plugin-suppression
.Note the Analytics link in the admin menu should also consistently deep-link to the Analytics section of the settings screen.
Screenshots
No response
PHP Version
No response
Plugin Version
2.2.2
AMP plugin template mode
Standard, Transitional, Reader
WordPress Version
No response
Site Health
No response
Gutenberg Version
No response
OS(s) Affected
No response
Browser(s) Affected
No response
Device(s) Affected
No response
Acceptance Criteria
No response
Implementation Brief
No response
QA Testing Instructions
No response
Demo
No response
Changelog Entry
No response
The text was updated successfully, but these errors were encountered: