Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Plugin Suppression section is scrolled into view when deep linked #7005

Closed
westonruter opened this issue Mar 29, 2022 · 4 comments · Fixed by #7051
Closed

Ensure Plugin Suppression section is scrolled into view when deep linked #7005

westonruter opened this issue Mar 29, 2022 · 4 comments · Fixed by #7051
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Milestone

Comments

@westonruter
Copy link
Member

Bug Description

As noted by @pooja-muchandikar in #5340 (comment):

If Suppressed on AMP Pages link is clicked from plugin screen, it should redirect to AMP settings > Plugin Suppression section. But currently it is redirecting to AMP settings > Review Section

Issue is specifically in Chrome Browser latest version
In Safari Browser latest version it is working fine.

Screen.Recording.2022-03-23.at.4.21.53.PM.mov

I think this is a separate issue with the Settings screen. Namely, I think the Review section is loaded asynchronously after the scrolling has started so that once the scrolling ends up the Review section and not Plugin Suppression.

Nevertheless, I am not able to reproduce the issue right now.

Expected Behaviour

The Plugin Suppression section should be scrolled into view when linking to /wp-admin/admin.php?page=amp-options#plugin-suppression.

Note the Analytics link in the admin menu should also consistently deep-link to the Analytics section of the settings screen.

Screenshots

No response

PHP Version

No response

Plugin Version

2.2.2

AMP plugin template mode

Standard, Transitional, Reader

WordPress Version

No response

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

No response

Browser(s) Affected

No response

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@westonruter westonruter added the Bug Something isn't working label Mar 29, 2022
@westonruter westonruter added this to the v2.2.3 milestone Mar 29, 2022
@dhaval-parekh dhaval-parekh self-assigned this Apr 4, 2022
@dhaval-parekh
Copy link
Collaborator

@pooja-muchandikar Can you please provide a specific Browser and it's the version where you were facing this issue?
And if you can provide screen resolution that will be great..

@pooja-muchandikar
Copy link

pooja-muchandikar commented Apr 6, 2022

@dhaval-parekh Following are the details where issue was observed.

AMP Mode: Standard

Browser Details:
Chrome Version 100.0.4896.60 (Official Build)

Screen Resolutions Tested:
1440x900 and 1280×640

NOTE: Redirections is working fine with above resolution in safari browser(v14 and v15)

@pooja-muchandikar
Copy link

QA Passed ✅ With One Regression Issue.

Chrome Version 102.0.5005.61, Also checked with Chrome Version 100.0.4896.60 -> Review Plugin Suppression is redirected/scrolled to proper section.


But Found one regression issue(Browser Safari Version 14.0.3 and Safari 15.3) When the Review Plugin Suppression is scrolled to review section the menu from left sidebar scrolls upwards. Because of the UI is not looking good. Observe the sidebar in following screenshots.


Chrome Browser Scroll:

image


Safari Browser Scroll:

screenshot_2022-06-06_at_5 04 55_pm


@westonruter
Copy link
Member Author

That would seem like it is a bug in WordPress core and not something we should worry about.

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants