Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent theme with AMP incompatibilities is greyed-out in the Site Scan results #6958

Closed
delawski opened this issue Mar 5, 2022 · 2 comments · Fixed by #6859
Closed

Parent theme with AMP incompatibilities is greyed-out in the Site Scan results #6958

delawski opened this issue Mar 5, 2022 · 2 comments · Fixed by #6859
Assignees
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes. Site Scanning
Milestone

Comments

@delawski
Copy link
Collaborator

delawski commented Mar 5, 2022

Bug Description

When both a child theme and its parent cause AMP incompatibilities, the parent theme appears to be inactive in the Site Scan results. This affects AMP Settings screen and in the Onboarding Wizard.

Expected Behaviour

Both child and the parent theme should be displayed as active (similarly to plugins) if they cause AMP incompatibilities.

Screenshots

Screenshot 2022-03-05 at 13 12 07

PHP Version

No response

Plugin Version

2.2.1

AMP plugin template mode

Standard, Transitional

WordPress Version

5.9

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

No response

Browser(s) Affected

No response

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@delawski delawski added Bug Something isn't working Site Scanning labels Mar 5, 2022
@delawski delawski added this to the v2.2.2 milestone Mar 5, 2022
@delawski delawski self-assigned this Mar 5, 2022
@delawski
Copy link
Collaborator Author

delawski commented Mar 5, 2022

This has been discovered while working on #6814 / #6859.

@pooja-muchandikar
Copy link

QA Passed ✅

Before: Parent theme being greyed out

parent-theme-after-scan-greyed-out


After: Parent theme looks fine

parent-theme-after-scan-looks-fine


@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes. Site Scanning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants