Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 Warning #6921

Closed
fellyph opened this issue Feb 16, 2022 · 1 comment · Fixed by #6948
Closed

PHP 8 Warning #6921

fellyph opened this issue Feb 16, 2022 · 1 comment · Fixed by #6948
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Milestone
v2.2.2

Comments

@fellyph
Copy link
Collaborator

fellyph commented Feb 16, 2022

Bug Description

A user at the AMP Support forum reported the following warning:

[09-Feb-2022 19:33:57 UTC] PHP Warning: Undefined array key "url" in /home/../wp-content/plugins/amp/src/Validation/ScannableURLsRestController.php on line 181 [09-Feb-2022 19:33:57 UTC] PHP Warning: Undefined array key "url" in /home/../wp-content/plugins/amp/src/Validation/ScannableURLsRestController.php on line 186

Expected Behaviour

Not display the warnings on PHP 8

Screenshots

No response

PHP Version

8.0.13

Plugin Version

2.2.1

AMP plugin template mode

Standard

WordPress Version

5.9

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

No response

Browser(s) Affected

No response

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response
@fellyph fellyph added the Bug Something isn't working label Feb 16, 2022
@westonruter westonruter added this to the v2.2.2 milestone Feb 16, 2022
@dhaval-parekh dhaval-parekh self-assigned this Feb 16, 2022
@dhaval-parekh
Copy link
Collaborator

I'm not able to reproduce this issue with PHP version 8.0.16, And with same the AMP configuration provided in ampwp-16f02fc7-3324-5533-882a-b1cb9de83705 support request.

Waiting for further information from WordPress.org support

@dhaval-parekh dhaval-parekh mentioned this issue Mar 1, 2022
Merged
2 tasks
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging a pull request may close this issue.

Suppress 'Undefined array key url' warning for PHP 8.0 ampproject/amp-wp
3 participants
@westonruter @fellyph @dhaval-parekh