Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site scan fail with custom post type #6855

Closed
fellyph opened this issue Jan 25, 2022 · 5 comments · Fixed by #6856
Closed

Site scan fail with custom post type #6855

fellyph opened this issue Jan 25, 2022 · 5 comments · Fixed by #6856
Assignees
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes. Site Scanning
Milestone

Comments

@fellyph
Copy link
Collaborator

fellyph commented Jan 25, 2022

Bug Description

When the user selects only a custom post type to be served by AMP, at the plugin's settings the site scan fails. To reproduce this behavior, I have created a simple custom post type and selected only this CPT to be served by AMP. The result is, the site scan started to fail because wasn't able to find AMP URLs.

Expected Behaviour

If the user selects a specific custom post type, the site scan should be able to point to the new URLs

Screenshots

Selecting Custom post type
Screen Shot 2022-01-25 at 16 30 52

Site scan results
Screen Shot 2022-01-25 at 16 29 44

Site scan URLs not available
Screen Shot 2022-01-25 at 16 33 01

PHP Version

7.4

Plugin Version

2.2

AMP plugin template mode

Reader

WordPress Version

5.8.3

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

Mac

Browser(s) Affected

Chrome

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@fellyph fellyph added the Bug Something isn't working label Jan 25, 2022
@westonruter
Copy link
Member

Did you create a Movie post in addition to having registered the post type?

@fellyph
Copy link
Collaborator Author

fellyph commented Jan 25, 2022

Hi @westonruter,

No, I haven't it was empty when I checked.
When I've included one Movie post it is working fine.
Screen Shot 2022-01-25 at 22 38 47

@westonruter
Copy link
Member

OK, then that's probably a pretty rare scenario, right?

If anything, when no scannable URLs are returned perhaps a special notice should be displayed saying that no URLs are available. This would be better and more specific than "Site scan failed. Try again."

@fellyph
Copy link
Collaborator Author

fellyph commented Jan 25, 2022

Sure, this is a rare scenario.

The message is not clear, that is why I got confused.

For example, if no post type is selected a different message is displayed:

Screen Shot 2022-01-25 at 23 50 19

@fellyph
Copy link
Collaborator Author

fellyph commented Jan 29, 2022

QA Passed

Site scan before:
Screen Shot 2022-01-29 at 08 43 39

Site scan version 2.2.x:
Screen Shot 2022-01-29 at 08 44 43

@westonruter westonruter added Changelogged Whether the issue/PR has been added to release notes. Site Scanning labels Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes. Site Scanning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants