Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facilitate users to share validation issues with 3rd party theme/plugin developers #6807

Closed
westonruter opened this issue Dec 22, 2021 · 1 comment · Fixed by #6835
Closed
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one P0 High priority
Milestone

Comments

@westonruter
Copy link
Member

westonruter commented Dec 22, 2021

Feature Description

When a user indicates they are not technically savvy, we hide links to the Validated URLs screen. When Site Scanning completes, we list the plugins and themes that have AMP validation issues, and then we again only show the link to the Validated URLs screen if the user is technical. This is problematic in the case where a user may want to report validation errors to a theme/plugin developer. In fact, as per #4668 we want to encourage this as much as possible instead of having all support requests go through the AMP plugin forum.

This was originally requested by @futtta in a support topic:

Remaining question (remark); it would be great if the “site scanner” could provide more technical info (hidden by default) for users to pass on to developers of conflicting plugins/ themes 🙂

Given the Site Scan results where we currently list each theme/plugin on a separate row:

image

I suggest that we make each line item expandable. When expanded, we can show:

  1. The URLs on which the plugin/theme has validation errors occurring. (We currently show this when activating a plugin, but we don't have this useful information as part of the full Site Scanning.)
  2. A summary of the validation errors. This likely should be similar to the “Raw data” field on the Support screen along with a button to copy to the clipboard. In fact, this would be very similar to the capability we have to copy validation errors to the clipboard from the Validated URL screen in Add buttons to copy error details to clipboard #5500. So there could be a button saying in effect “Copy validation data to share with developer”. This could be also incorporated into the plugin post-activation scan notice.

The version information could be shown in the expanded view (along with other metadata), instead of showing it floated to the right.

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@westonruter westonruter added the Enhancement New feature or improvement of an existing one label Dec 22, 2021
@westonruter westonruter added this to the v2.3 milestone Dec 22, 2021
@westonruter westonruter added the P0 High priority label Dec 23, 2021
@dhaval-parekh dhaval-parekh self-assigned this Jan 10, 2022
@maitreyie-chavan maitreyie-chavan modified the milestones: v2.3, v2.2.2 Feb 8, 2022
@pooja-muchandikar
Copy link

QA Passed ✅ for the new enhancement implemented.

Before: On Site Scan screen links were hidden for non-technical savvy

Screenshot 2022-03-23 at 11 01 37 AM


After: On Site Scan screen links are displayed for non-technical savvy

Screenshot 2022-03-23 at 11 01 25 AM


But found an regression issue on Safari Browser Version 14.0.3

Though it is working fine in latest Safari Version 15.03

On site scan screen from AMP settings page and also on Onboarding Wizard, the error displayed for theme/plugins are not aligned. The title of plugin/theme appears below the arrow

Onboarding Wizard Screen

Screenshot 2022-03-23 at 11 00 02 AM


Site scan AMP settings screen

Screenshot 2022-03-23 at 11 00 38 AM

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one P0 High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants