Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting AMP-compatible themes and plugins in network theme/plugin screens is not working properly. #6725

Closed
dhaval-parekh opened this issue Nov 17, 2021 · 2 comments · Fixed by #6726
Assignees
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes. P0 High priority
Milestone

Comments

@dhaval-parekh
Copy link
Collaborator

Bug Description

The highlighting theme and plugin are not working properly in the network theme and plugin screens in the MU site setup.

Installed Themes.

The AMP-compatible theme does not show the message of "AMP Compatible" as we show on the installed plugin page.
image

Add New Theme.

The "AMP Compatible" tab and "AMP Compatible" badges are missing.
image

Add New Plugin (Populer Tab)

The "AMP Compatible" badges are missing.
image

Add New Plugin (AMP Compatible Tab)

Additional detail section are rendring.
image

Expected Behaviour

Installed Themes.

  • Show "AMP Compatible" message beside the theme author and theme site link.

Add New Theme.

  • Add "AMP Compatible" badge for AMP-compatible themes.
  • Add the "AMP Compatible" tab which shows a list of AMP-compatible themes.

Add New Plugin (Populer Tab)

  • Add "AMP Compatible" badge for AMP-compatible plugins.

Add New Plugin (AMP Compatible Tab)

  • Remove addition detail section from plugin card.

image

Screenshots

No response

PHP Version

No response

Plugin Version

2.2-alpha

AMP plugin template mode

Standard, Transitional, Reader

WordPress Version

No response

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

No response

Browser(s) Affected

No response

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@dhaval-parekh dhaval-parekh added Bug Something isn't working P0 High priority labels Nov 17, 2021
@dhaval-parekh dhaval-parekh self-assigned this Nov 17, 2021
@dhaval-parekh
Copy link
Collaborator Author

Related to #2313

@delawski
Copy link
Collaborator

delawski commented Nov 29, 2021

QA Passed

The AMP Compatible badges are displayed on Add Theme and Add Plugin screens in a Multisite setup.

Add Theme Add Plugin
Screenshot 2021-11-29 at 23 38 05 Screenshot 2021-11-29 at 23 37 41
Add Theme
External link if not leading to wp.org
Add Plugin
External link if not leading to wp.org
Screenshot 2021-11-29 at 23 38 33 Screenshot 2021-11-29 at 23 38 58
Themes
AMP Compatible label
Plugins
AMP Compatible label
Screenshot 2021-11-29 at 23 48 13 Screenshot 2021-11-29 at 23 47 50

Tested on AMP Version 2.2.0-alpha-20211123T020732Z-5405daa

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes. P0 High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants