Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure any changes to the "Enable Developer Tools" option reload the page to in #6714

Closed
jamesozzie opened this issue Nov 11, 2021 · 1 comment · Fixed by #6878
Closed

Ensure any changes to the "Enable Developer Tools" option reload the page to in #6714

jamesozzie opened this issue Nov 11, 2021 · 1 comment · Fixed by #6878
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes. P2 Low priority
Milestone

Comments

@jamesozzie
Copy link
Collaborator

Bug Description

When a user changes the status of the "Enable Developer Tools" option and saves their AMP settings the additional tabs enabled/disabled by this toggle don't appear until the page is reloaded or exited. The 2 tabs are:

  • Validated URLs
  • Error Index

image

image

Consider refreshing the page upon any changes to this setting, once a user "Saves" their settings.

Expected Behaviour

The associated tabs that are enabled/disabled should be visible/removed upon saving any AMP configurations

Screenshots

2021-11-11-17-28-32

PHP Version

No response

Plugin Version

2.2.0 Alpha

AMP plugin template mode

Transitional

WordPress Version

5.8.2

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

No response

Browser(s) Affected

All

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@pooja-muchandikar
Copy link

QA Passed ✅

Before: Tabs were not getting enabled/disabled and explicit refresh was necessary.

Options.being.removed.fetched.on.page.refresh.mov

After: Tabs are now getting enabled/disabled as soon as AMP settings are saved.

Options.being.removed.fetched.immediately.mov

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes. P2 Low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants