Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up Site Scan by doing up to 3 requests in parallel (with staggering) #6691

Closed
westonruter opened this issue Nov 5, 2021 · 2 comments · Fixed by #6705
Closed

Speed up Site Scan by doing up to 3 requests in parallel (with staggering) #6691

westonruter opened this issue Nov 5, 2021 · 2 comments · Fixed by #6705
Assignees
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one P1 Medium priority Site Scanning
Milestone

Comments

@westonruter
Copy link
Member

Feature Description

The time it takes to perform a Site Scan could be sped up if some of the validation requests were parallelized. We wouldn't want to do too many requests in parallel for fear of overloading shared hosts, but up to 3 requests at a time seems reasonable. Additionally, in order to show some semblance of continuous progression in the progress bar and to avoid making multiple requests at exactly the same moment, it would make sense to initiate each subsequent request after a 500ms delay.


Note: Eventually on the Settings screen we'll want to not use a progress bar but instead list out all of the scannable URLs (which would potentially be customizable by the user) and then for each show a status:

  • In progress ⌛
  • Has incompatibilities ⚠️
  • All compatible ✅

Each URL can then link off to each respective Validated URL screen.

But this is to address later.

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@westonruter westonruter added Enhancement New feature or improvement of an existing one P1 Medium priority labels Nov 5, 2021
@westonruter westonruter added this to the v2.2 milestone Nov 5, 2021
@fellyph fellyph self-assigned this Dec 10, 2021
@fellyph
Copy link
Collaborator

fellyph commented Dec 10, 2021

QA Passed

Screen Shot 2021-12-10 at 16 22 55

  • Slow 3g
  • PHP 8
  • PHP 7.4.1
  • PHP 5.6
  • WordPress 5.8.2
  • WordPress 5.9 Beta

@westonruter
Copy link
Member Author

Great screenshot depicting what is going on! 👍

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one P1 Medium priority Site Scanning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants