Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve action items for when there are theme/plugin incompatibilities #6689

Closed
5 tasks
westonruter opened this issue Nov 5, 2021 · 1 comment · Fixed by #6698
Closed
5 tasks

Improve action items for when there are theme/plugin incompatibilities #6689

westonruter opened this issue Nov 5, 2021 · 1 comment · Fixed by #6698
Assignees
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one P0 High priority Site Scanning
Milestone

Comments

@westonruter
Copy link
Member

westonruter commented Nov 5, 2021

Feature Description

Currently when there are either theme or plugin compatibility issues, the same copy appears in a paragraph above boxes containing the incompatible themes and plugins.

  • The action item to review and suppress plugins should rather only appear if there are plugins with incompatibilities, and this action item should appear inside the plugins box.
  • In the incompatible themes box, this is probably where the recommendation to change to Reader mode should be. Or else to consider switching to an alternative theme (see below).
  • In the boxes for themes and plugins, there should be links to the AMP Compatible tabs for the the Theme Install and Plugin Install screens, if theme/plugin installation is available (i.e. if filesystem is not read only). If the theme/plugin installation is not available, there should rather be ExternalLinks going to the theme/plugin ecosystem pages on amp-wp.org.
  • When a site scan completes, the suppressed_plugins option should be re-fetched so that the suppressed table is updated with which plugins have validation errors.
  • Discontinue doing synchronous re-validation of validated URLs when updating suppressed plugins. Instead of doing this, initiating a re-scan should be done.

image

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@westonruter westonruter added Enhancement New feature or improvement of an existing one P0 High priority labels Nov 5, 2021
@westonruter westonruter added this to the v2.2 milestone Nov 5, 2021
@westonruter westonruter changed the title Improve action items for when there are theme/plugin imcompatibilities Improve action items for when there are theme/plugin incompatibilities Nov 5, 2021
@dhaval-parekh dhaval-parekh self-assigned this Dec 2, 2021
@dhaval-parekh
Copy link
Collaborator

QA Passed

✅ When there are incompatible plugins. It provides a link to suppress plugins and provide a link to browse AMP-compatible plugins.
image

✅ When there is an incompatible theme. It shows a message to change templated mode and provide a link to browse AMP-compatible themes.
image

However, I noticed that in a multisite setup ( and when a user is super admin ) It does redirect to the network screen of the respective theme/plugin screen. but not to the "AMP Compatible" tab. cc: @delawski

✅ It re-fetch the list of suppressed plugins once site scanning is completed.

✅ Initiating a site scan once suppressed plugin is updated.

AMP-GH-6689.mov

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one P0 High priority Site Scanning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants