Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Stylesheets Box on Validated URL Screen #6441

Closed
4 tasks
delawski opened this issue Jul 1, 2021 · 6 comments · May be fixed by #6442
Closed
4 tasks

Revamp Stylesheets Box on Validated URL Screen #6441

delawski opened this issue Jul 1, 2021 · 6 comments · May be fixed by #6442
Assignees
Labels
Developer Tools Enhancement New feature or improvement of an existing one P2 Low priority

Comments

@delawski
Copy link
Collaborator

delawski commented Jul 1, 2021

Feature description

Following the strangler fig approach, the "Stylesheets" meta box on the Validated URL screen is a good first candidate to go through the redesign process (#2316).

Screenshot 2021-07-01 at 14 57 07

Right now, it uses the regular WordPress functionality, i.e. list tables and admin hooks.

The aim of this issue is to replace the server-side rendered meta box with a React-based component fed via the REST API.

It will require the following to be done:

  • Create a new REST endpoint, GET /wp-json/amp/v1/validated-urls/:id/, that will return the validation data stored in a amp_validated_url post type. For now, the response data structure will be limited to just the stylesheets data structure (along with some general fields like id, url, date, etc.).
  • Ensure the REST endpoint is secure so that only authorized users are receiving the validation data.
  • Implement a new React component that will look similar to the existing "Stylesheets" meta box. It should incorporate any applicable usability improvements described in Update to validator with usability improvements #5191.
  • Remove the legacy "Stylesheets" meta box along with code dependencies.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@delawski delawski added Enhancement New feature or improvement of an existing one Developer Tools WS:UX Work stream for UX/Front-end labels Jul 1, 2021
@delawski delawski self-assigned this Jul 1, 2021
@delawski delawski added this to the v2.2 milestone Jul 1, 2021
@westonruter westonruter added the P0 High priority label Jul 3, 2021
@jwold
Copy link
Collaborator

jwold commented Jul 13, 2021

@delawski in our last Leads meeting, Alberto asked if we could add a note that the % column is difficult for users to understand. There are some challenges with differentiating between 71% and 49%, for instance. Is this something we could put in numbers visually, or replace the bar with %? The bar itself isn't quite enough to convey what's happening.

cc @amedina and @westonruter

@delawski
Copy link
Collaborator Author

@jwold That's a good point. Yes, I think we can definitely add a number next to or above the bar, or replace the bar entirely with a number. If you have a suggestion on what would work better, please share.

@jwold
Copy link
Collaborator

jwold commented Jul 13, 2021

I'm thinking in this case we may want to replace the bar entirely just with percentages. Does that make sense?

@jwold
Copy link
Collaborator

jwold commented Jul 13, 2021

Screen%20Shot%202021-07-13%20at%2014 21 29

@westonruter
Copy link
Member

Yes, I think replacing the bar with percentage numbers makes sense, or a number overlaying the bar as I recall seeing Ken show a design mock for.

Originally I was just trying to find a good use of meter. But it's problematic as shown in your screenshot when there are many small CSS files along with one big one, as it is not clear what is going on.

@maitreyie-chavan maitreyie-chavan removed the WS:UX Work stream for UX/Front-end label Aug 20, 2021
@jwold
Copy link
Collaborator

jwold commented Sep 22, 2021

This is ready for review but is parked. Building block piece not required to address for narrative. Not needed for 2.2, and needs further iterations in the future. Hence not being prioritized.

@maitreyie-chavan maitreyie-chavan added P2 Low priority and removed P0 High priority labels Sep 28, 2021
@westonruter westonruter modified the milestones: v2.2, v2.3 Sep 28, 2021
@westonruter westonruter modified the milestones: v2.3, v2.4 Dec 23, 2021
@westonruter westonruter removed this from the v2.4 milestone Apr 14, 2022
@westonruter westonruter closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Tools Enhancement New feature or improvement of an existing one P2 Low priority
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants