-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the themes and plugins that are causing AMP validation errors within the block editor sidebar #5697
Comments
@westonruter and @johnwatkins0 I've created this new ticket for the discussion from: #3821 (comment) |
@jwold I was thinking of it basically augmenting what @johnwatkins0 has here in #5589: Above the "Validation Errors" section there could be two new ones for "Incompatible Themes" and "Incompatible Plugins". Or rather, instead of "Validation Errors" that section could be renamed to be just "Compatibility Issues", and then there could be the list of themes/plugins, and then following that the list of the individual validation errors. (Possibly clicking a theme or plugin could serve as a filter to limit the validation errors that appear below.) As discussed in #3821 (comment), if the user has DevTools turned off, the list of validation errors could be hidden by default behind a button. |
This captures most of what was outlined above, and in #3821. It's a bit clunky, but worth discussing. |
I feel good about the iterations on this as discussed over VC. |
Proposing an approach. This applies to plugins but probably works similarly with themes. When the AMP plugin finds a validation error associated with a plugin it has not encountered before, we will:
plugins_api(
'plugin_information',
[
'slug' => 'jetpack',
'fields' => [
'icons' => true, // Returns icons associated with the plugin.
],
]
); If the
IconsWhile we're using We are not including plugin icons in the initial iteration of the editor sidebar (see #5589) because we would need to use |
Yes, that should always be the case.
Perfect.
Yes, it could probably be cached for a year, in the case of a non-error response to
Great! |
Feature description
This expands on our work in #3821 and relates to #4668.
Acceptance Criteria
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: