Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum font size not working with Heading block #5658

Closed
priethor opened this issue Dec 4, 2020 · 4 comments
Closed

Maximum font size not working with Heading block #5658

priethor opened this issue Dec 4, 2020 · 4 comments
Labels

Comments

@priethor
Copy link

priethor commented Dec 4, 2020

Bug Description

The maximum font size settings set to a Heading block are not applied

Expected Behaviour

When browsing the edited page from a mobile device, the text should fit in the screen, with a font size smaller than the maximum specified in the AMP settings.

Steps to reproduce

  1. Select a Heading block
  2. Enable AMP Settings
  3. Set a max font size smaller than the normal font size
  4. The AMP max font size doesn't apply and the Heading block spans two lines, as in the following screenshot

Screenshots

image

Additional context

  • WordPress version: 5.5.3
  • Plugin version: 2.0.7
  • Gutenberg plugin version (if applicable): 9.5.0
  • Browser: Chrome, Firefox

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter
Copy link
Member

Are you referring to the “Automatically fit text to container” setting, like:

image

If so, we're actually planning on deprecate and remove this feature due to it not currently working on non-AMP pages and also that it is too low-level. It's more relevant when the text is programmatically supplied rather than being manually entered. See #4557 (comment).

@priethor
Copy link
Author

priethor commented Dec 7, 2020

Are you referring to the “Automatically fit text to container” setting, like:

Yes, that's the one I was referring to.

@westonruter
Copy link
Member

OK, please disregard that feature for now. We'll be deprecating/removing it.

@westonruter
Copy link
Member

Closing in favor of #4557.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants