Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin settings page: Handle plugin suppression table via REST/React #5014

Closed
johnwatkins0 opened this issue Jul 9, 2020 · 0 comments · Fixed by #5040
Closed

Plugin settings page: Handle plugin suppression table via REST/React #5014

johnwatkins0 opened this issue Jul 9, 2020 · 0 comments · Fixed by #5040
Assignees
@westonruter
Labels
Changelogged Whether the issue/PR has been added to release notes. UX WS:UX Work stream for UX/Front-end
Milestone
v2.0

Comments

@johnwatkins0
Copy link
Contributor

johnwatkins0 commented Jul 9, 2020 •
edited
Loading

Feature description

In #4998 the plugins settings page rebuilt using REST endpoints and components created for the onboarding wizard. Converting the Plugin Suppression table to this approach was deferred due to the size of the task.

Current screenshot:

Screen Shot 2020-07-09 at 5 02 47 PM

Acceptance criteria

  • Plugin suppression table shows when .... (need to nail down the conditions for this)
  • User can manage plugin suppression as they do now

Implementation brief

  • Can probably manage fetching/saving data using the AMP Options endpoint
  • Core components with AMP plugin style can be used for most of it

QA testing instructions

Demo

Changelog entry
@johnwatkins0 johnwatkins0 added UX WS:UX Work stream for UX/Front-end labels Jul 9, 2020
@westonruter westonruter added this to the v1.6 milestone Jul 9, 2020
@westonruter westonruter mentioned this issue Jul 9, 2020
Closed
@johnwatkins0 johnwatkins0 self-assigned this Jul 10, 2020
@johnwatkins0 johnwatkins0 mentioned this issue Jul 14, 2020
Merged
3 tasks
@johnwatkins0 johnwatkins0 mentioned this issue Jul 14, 2020
Merged
3 tasks
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 17, 2020
@kmyram kmyram assigned westonruter and unassigned johnwatkins0 Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westonruter westonruter

Labels
Changelogged Whether the issue/PR has been added to release notes. UX WS:UX Work stream for UX/Front-end
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Plugin settings: Handle plugin suppression section with REST/React components ampproject/amp-wp
2 participants
@westonruter @johnwatkins0