Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Analytics Options submenu into "Advanced" section of settings page #5013

Closed
johnwatkins0 opened this issue Jul 9, 2020 · 3 comments · Fixed by #5155
Closed

Move Analytics Options submenu into "Advanced" section of settings page #5013

johnwatkins0 opened this issue Jul 9, 2020 · 3 comments · Fixed by #5155
Assignees
@westonruter
Labels
Changelogged Whether the issue/PR has been added to release notes. Groomed P1 Medium priority UX WS:UX Work stream for UX/Front-end
Milestone
v2.0

Comments

@johnwatkins0
Copy link
Contributor

Feature description

Mentioned by @westonruter here: #4998 (comment)

Acceptance criteria

  • No more Analytics Options menu
  • Form exists on settings page in a section that can be expanded/collapsed

Implementation brief

  • Handle fetching, updating data via the AMP Options REST endpoint

QA testing instructions

Demo

Changelog entry
@johnwatkins0 johnwatkins0 added this to the v1.7 milestone Jul 9, 2020
@johnwatkins0 johnwatkins0 added UX WS:UX Work stream for UX/Front-end labels Jul 9, 2020
@johnwatkins0 johnwatkins0 removed this from the v1.7 milestone Jul 9, 2020
@westonruter
Copy link
Member

Also referenced in #2317 (comment), which may or may not be resolved by whatever PR closes this.

@westonruter
Copy link
Member

While not as important as #5014 or #5015, this would be great to include in 1.6 because then we can eliminate all of the old form-based options processing in favor of exclusively using the REST API.

@westonruter westonruter added this to the v1.6 milestone Jul 13, 2020
@kmyram kmyram added P0 High priority P1 Medium priority Groomed and removed P0 High priority labels Jul 21, 2020
@westonruter
Copy link
Member

Note that with this and #5100 there will no longer be a need for \AMP_Options_Manager::add_settings_error(). It can be deleted.

@johnwatkins0 johnwatkins0 mentioned this issue Aug 3, 2020
Merged
3 tasks
@westonruter westonruter mentioned this issue Aug 6, 2020
Closed
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Aug 8, 2020
@kmyram kmyram assigned westonruter and unassigned johnwatkins0 Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westonruter westonruter

Labels
Changelogged Whether the issue/PR has been added to release notes. Groomed P1 Medium priority UX WS:UX Work stream for UX/Front-end
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Add Analytics option to settings screen ampproject/amp-wp
3 participants
@westonruter @kmyram @johnwatkins0