Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Reader Mode users to chose a theme from a curated list #4560

Closed
amedina opened this issue Apr 10, 2020 · 2 comments · Fixed by #4998
Closed

Allow Reader Mode users to chose a theme from a curated list #4560

amedina opened this issue Apr 10, 2020 · 2 comments · Fixed by #4998
Labels
Changelogged Whether the issue/PR has been added to release notes. Reader Mode RME Reader Mode Expansion WS:UX Work stream for UX/Front-end
Milestone
v2.0

Comments

@amedina
Copy link
Member

amedina commented Apr 10, 2020 •
edited
Loading

Upon activating the plugin and/or selecting Reader Mode, the user will be provided with a set of pre-defined themes to chose from (a subset of themes in ecosystem page)
@westonruter westonruter added Reader Mode RME Reader Mode Expansion labels Apr 11, 2020
@kmyram kmyram added this to the Sprint 27 milestone Apr 14, 2020
This was referenced Apr 27, 2020
Closed
Closed
@johnwatkins0 johnwatkins0 mentioned this issue May 24, 2020
Closed
@westonruter westonruter modified the milestones: Sprint 27, v1.6 Jun 2, 2020
@westonruter
Copy link
Member

@johnwatkins0 Assigning this to you since this is what you built as part of the wizard (#4702) and also what you'll be adding to the admin settings screen (#4704).

The plumbing of actually loading the selected Reader theme is what I'm working on in #4478.

@westonruter westonruter mentioned this issue Jul 4, 2020
Merged
7 tasks
@westonruter
Copy link
Member

As noted in #4984, when selecting a non-legacy theme in Reader mode, the same UI to “show all templates as AMP” and the ability to select individual templates needs to be offered. These options should be disabled when the Legacy theme is selected.

@johnwatkins0 johnwatkins0 mentioned this issue Jul 7, 2020
Merged
3 tasks
@kmyram kmyram assigned westonruter and unassigned johnwatkins0 Jul 15, 2020
@westonruter westonruter removed their assignment Jul 16, 2020
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 17, 2020
@kmyram kmyram added the WS:UX Work stream for UX/Front-end label Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes. Reader Mode RME Reader Mode Expansion WS:UX Work stream for UX/Front-end
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Settings screen updates ampproject/amp-wp
4 participants
@westonruter @amedina @kmyram @johnwatkins0