Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of validation errors in Reader Mode #4480

Closed
amedina opened this issue Mar 31, 2020 · 1 comment · Fixed by #4955
Closed

Improve handling of validation errors in Reader Mode #4480

amedina opened this issue Mar 31, 2020 · 1 comment · Fixed by #4955
Assignees
Labels
Changelogged Whether the issue/PR has been added to release notes. P0 High priority RME Reader Mode Expansion UX WS:UX Work stream for UX/Front-end
Milestone

Comments

@amedina
Copy link
Member

amedina commented Mar 31, 2020

In Reader Mode validation errors are silently suppressed so users have no idea when something is being removed for being invalid.

Note: that validation error messages used to be present in Reader mode, but they were removed in #1132 because users were complaining about seeing undesired warnings (apparently ignorance is bliss).

The new Reader mode theme will need to trigger the standard theme hooks including wp_head and wp_footer so that scripts and stylesheets that a plugin may be trying to the page will be included and then reported as validation errors. This would have illuminated the reason for breakages such as ampproject/amphtml#26622.

Of course, there is still going to be the need to suppress validation errors from certain user roles or on certain site configurations (e.g. WordPress.com). This is needed for Standard/Transitional mode already.

It would also need to be available in Reader mode. See #2673.

@westonruter
Copy link
Member

Closely related to #3821

@kmyram kmyram added the WS:UX Work stream for UX/Front-end label May 15, 2020
@kmyram kmyram modified the milestones: Sprint 28, v1.6 May 27, 2020
@kmyram kmyram assigned amedina and unassigned westonruter Jul 15, 2020
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. P0 High priority RME Reader Mode Expansion UX WS:UX Work stream for UX/Front-end
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants