Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard only: Page reordering from carousel #10

Closed
miina opened this issue Jan 15, 2020 · 1 comment
Closed

Keyboard only: Page reordering from carousel #10

miina opened this issue Jan 15, 2020 · 1 comment
Labels
Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Group: Carousel Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar P3 Nice to have Type: Enhancement New feature or improvement of an existing feature

Comments

@miina
Copy link
Contributor

miina commented Jan 15, 2020 •
edited by swissspidy
Loading

Feature description

Followup issue for #94 to add the functionality for being able to reorder using keyboard only.

Note that this is blocked by ampproject/amp-wp#3826

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Pages can be reordered using keyboard only
  • Clicking [?] will start dragging (a clone)
  • Left and right arrow can be used to move the thumbnail to the left or right (mind the limits)
  • Clicking [?] will stop dragging and reorder the pages.

Implementation brief

QA testing instructions

Demo

Changelog entry
@miina miina self-assigned this Jan 15, 2020
@swissspidy swissspidy transferred this issue from ampproject/amp-wp Jan 23, 2020
@swissspidy swissspidy added Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Type: Enhancement New feature or improvement of an existing feature labels Jan 23, 2020
@merapi merapi mentioned this issue Feb 25, 2020
Closed
@merapi
Copy link
Contributor

merapi commented Feb 26, 2020

Note: this is now unblocked (#119)

@merapi merapi mentioned this issue Feb 26, 2020
Merged
@jauyong jauyong added the Size: M label Mar 6, 2020
@kmyram kmyram added this to the Sprint 25 milestone Mar 9, 2020
@kmyram kmyram removed the Size: M label Apr 16, 2020
@jauyong jauyong added the P2 Should do soon label Apr 27, 2020
@o-fernandez o-fernandez removed this from the Sprint 25 milestone May 6, 2020
@miina miina removed their assignment May 19, 2020
@barklund barklund added the Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar label Oct 5, 2020
@amovar18 amovar18 mentioned this issue Dec 22, 2021
Merged
8 tasks
@bmattb bmattb closed this as completed Jan 25, 2022
@bmattb bmattb reopened this Jan 25, 2022
@swissspidy swissspidy added P3 Nice to have and removed P2 Should do soon labels Oct 31, 2022
@swissspidy swissspidy closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Group: Carousel Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar P3 Nice to have Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@barklund @swissspidy @kmyram @miina @jauyong @o-fernandez @merapi @bmattb