Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI integration shows internal methods as commands #3102

Closed
schlessera opened this issue Aug 27, 2019 · 2 comments · Fixed by #3229
Closed

CLI integration shows internal methods as commands #3102

schlessera opened this issue Aug 27, 2019 · 2 comments · Fixed by #3229
Assignees
Labels
Bug Something isn't working WP-CLI
Milestone

Comments

@schlessera
Copy link
Collaborator

When I did work on refactoring the CLI commands, one of the initial steps was to make all internal methods private, so that the commands could act as command classes on their own.

Later, I noticed that the tests were built in such a way to require all internals to be public. So instead of rewriting all the tests, I opened another issue to introduce an abstraction layer (#3077) to remed this problem and come back to later. To make the tests pass for the build, I made the internals public again.

However, now, because of the changed command structure, all of the internal methods are exposed as subcommands because of this:
Image 2019-08-27 at 5 24 39 PM

@schlessera schlessera added Bug Something isn't working WP-CLI labels Aug 27, 2019
@schlessera schlessera self-assigned this Aug 27, 2019
@schlessera
Copy link
Collaborator Author

This should be solved before the next release OR #3079 should not be included in that release.

@kienstra
Copy link
Contributor

kienstra commented Sep 12, 2019

Thanks, I'll plan on code reviewing #3229 right away, and moving it to 'Ready For Merging' if/when it passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working WP-CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants