Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #2872

Closed
swissspidy opened this issue Jul 24, 2019 · 0 comments · Fixed by #3208
Closed

Remove deprecated code #2872

swissspidy opened this issue Jul 24, 2019 · 0 comments · Fixed by #3208
Assignees
Labels
Task Tasks which do not involve engineering
Milestone

Comments

@swissspidy
Copy link
Collaborator

As a follow-up to #876, where AMP_WP_Utils was deprecated, I think it is now time to fully remove that code.

A quick search on https://wpdirectory.net/ revealed exactly 0 plugins and themes that use any of these utils. There are only plugins (e.g. AMP for WP) that also have this class, but that's because they include this plugin here as a Composer dependency.

We could remove the code in the next bigger release, e.g. 1.3.0 or 2.0.0 the latest.

Similarly, we could remove other code that was deprecated in < 1.0, e.g. amp_load_classes()

@swissspidy swissspidy added the Task Tasks which do not involve engineering label Jul 24, 2019
@westonruter westonruter added this to the v1.3 milestone Jul 26, 2019
@schlessera schlessera self-assigned this Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Tasks which do not involve engineering
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants