Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMP Stories] Text Block: Autocomplete broken #1919

Closed
swissspidy opened this issue Mar 1, 2019 · 10 comments
Closed

[AMP Stories] Text Block: Autocomplete broken #1919

swissspidy opened this issue Mar 1, 2019 · 10 comments
Assignees
Labels
Bug Something isn't working Duplicate

Comments

@swissspidy
Copy link
Collaborator

When typing / (slash) to open the autocomplete, you'll see a menu like this:\

screenshot 2019-03-01 at 16 07 33

At the moment, clicking on these options is not possible. The following error appears in the console on click:

screenshot 2019-03-01 at 16 09 07

This might be an issue with the text block we added.

@swissspidy swissspidy changed the title [AMP Stories} Text Block: Autocomplete broken [AMP Stories] Text Block: Autocomplete broken Mar 1, 2019
@swissspidy swissspidy added Bug Something isn't working AMP-Stories labels Mar 1, 2019
@swissspidy
Copy link
Collaborator Author

Now the Autocomplete doesn't seem to work at all anymore 🤔

@miina Do you perhaps know what might have changed here off the top of your head?

@miina
Copy link
Contributor

miina commented Mar 18, 2019

@swissspidy Don't know the top of my head, I checked a few PR-s back and at the first glance it looks like it hasn't been working already for some time.

I'm happy to debug this after updating #1965 (unless you get to it first).

@miina miina self-assigned this Mar 20, 2019
@miina
Copy link
Contributor

miina commented Mar 20, 2019

FI: Starting looking into this now.

@westonruter
Copy link
Member

This issue seems to have regressed. I'm not able to get slash command completions anymore for the Text block:

image

@westonruter westonruter reopened this Apr 11, 2019
@swissspidy
Copy link
Collaborator Author

I just noticed that today. It seems to work with a completely fresh text block, but not after you have edited it already.

@westonruter
Copy link
Member

Oh, good observation. It doesn't work for the initial Text block that appears in the page, but it does work for Text blocks that are added thereafter.

@westonruter westonruter added this to the v1.2 milestone May 21, 2019
@westonruter westonruter modified the milestones: v1.2, v1.2.1 Jun 18, 2019
@westonruter
Copy link
Member

Moving to v1.2.1

@swissspidy
Copy link
Collaborator Author

Hmm I cannot reproduce this error anymore.

@miina
Copy link
Contributor

miina commented Jun 18, 2019

@swissspidy I think that you fixed it within #2633. If I understood correctly.

@swissspidy swissspidy removed this from the v1.2.1 milestone Jun 18, 2019
@swissspidy
Copy link
Collaborator Author

Ah, well then this is actually a duplicate of #2632 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Duplicate
Projects
None yet
Development

No branches or pull requests

4 participants