Sanotize img tags when src attribute contains only spaces. Fixes issue …

…#1030
ampproject · Apr 3, 2018 · a75f27d · a75f27d
1 parent 67a8a69
commit a75f27d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/includes/sanitizers/class-amp-img-sanitizer.php b/includes/sanitizers/class-amp-img-sanitizer.php
@@ -73,7 +73,7 @@ public function sanitize() {
 				continue;
 			}
 
-			if ( ! $node->hasAttribute( 'src' ) || '' === $node->getAttribute( 'src' ) ) {
+			if ( ! $node->hasAttribute( 'src' ) || '' === trim( $node->getAttribute( 'src' ) ) ) {
 				$this->remove_invalid_child( $node );
 				continue;
 			}

diff --git a/tests/test-amp-img-sanitizer.php b/tests/test-amp-img-sanitizer.php
@@ -27,6 +27,11 @@ public function get_data() {
 				'<p></p>',
 			),
 
+			'image_with_spaces_only_src'               => array(
+				'<p><img src="    " width="300" height="300" /></p>',
+				'<p></p>',
+			),
+
 			'image_with_empty_width_and_height'        => array(
 				'<p><img src="http://placehold.it/300x300" width="" height="" /></p>',
 				'<p><amp-img src="http://placehold.it/300x300" width="600" height="400" class="amp-wp-unknown-size amp-wp-enforced-sizes" sizes="(min-width: 600px) 600px, 100vw"></amp-img></p>',