Harden updates of submenu items

ampproject · Feb 22, 2021 · 8d90f2d · 8d90f2d
1 parent 70941a5
commit 8d90f2d
Showing 1 changed file with 8 additions and 11 deletions.
diff --git a/assets/src/amp-validation/counts/index.js b/assets/src/amp-validation/counts/index.js
@@ -1,8 +1,3 @@
-/**
- * External dependencies
- */
-import { isPlainObject } from 'lodash';
-
 /**
  * WordPress dependencies
  */
@@ -24,8 +19,6 @@ import './style.css';
  * @param {number} count Count to set.
  */
 function updateMenuItem( itemEl, count ) {
-	count = Math.abs( count );
-
 	if ( isNaN( count ) || count === 0 ) {
 		itemEl.parentNode.parentNode.removeChild( itemEl.parentNode );
 	} else {
@@ -37,18 +30,22 @@ function updateMenuItem( itemEl, count ) {
 /**
  * Updates the 'Validated URLs' and 'Error Index' menu items with their respective unreviewed count.
  *
- * @param {any} counts Counts for menu items.
+ * @param {Object} counts Counts for menu items.
  * @param {number} counts.validated_urls Unreviewed validated URLs count.
  * @param {number} counts.errors Unreviewed validation errors count.
  */
 function updateMenuItemCounts( counts ) {
 	const { validated_urls: newValidatedUrlCount, errors: newErrorCount } = counts;
 
 	const errorCountEl = document.getElementById( 'new-error-index-count' );
-	const validatedUrlsCountEl = document.getElementById( 'new-validation-url-count' );
+	if ( errorCountEl ) {
+		updateMenuItem( errorCountEl, newErrorCount );
+	}
 
-	updateMenuItem( errorCountEl, newErrorCount );
-	updateMenuItem( validatedUrlsCountEl, newValidatedUrlCount );
+	const validatedUrlsCountEl = document.getElementById( 'new-validation-url-count' );
+	if ( validatedUrlsCountEl ) {
+		updateMenuItem( validatedUrlsCountEl, newValidatedUrlCount );
+	}
 }
 
 /**