Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More robust cache warmup #835

Merged
merged 1 commit into from
Jun 11, 2020
Merged

More robust cache warmup #835

merged 1 commit into from
Jun 11, 2020

Conversation

sebastianbenz
Copy link
Collaborator

  • timeout fetch after 2s to avoid overly long timeouts
  • explain how to configure a custom proxy
  • fix potential endless loop if fetch fails

Fixes #832

patrickkettner
patrickkettner approved these changes Jun 11, 2020
View reviewed changes
packages/optimizer/README.md Outdated

- name: `fetch`
- valid options: a [whatwg fetch](https://github.com/whatwg/fetch) compatible fetch implementation.
- default: `[node-fetch](https://www.npmjs.com/package/node-fetch)`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to wrap a markdown link inside of code ticks?

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this was intenational, but not sure if it makes sense ;-)

@sebastianbenz sebastianbenz merged commit 0af1812 into master Jun 11, 2020
@merceyz merceyz mentioned this pull request Jun 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickkettner patrickkettner patrickkettner approved these changes

Assignees
No one assigned
Labels
bug cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors installing @ampproject/[email protected] behind proxy
3 participants
@sebastianbenz @patrickkettner @googlebot