Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[optimizer] add missing runtime dependencies #799

Merged
merged 4 commits into from
May 27, 2020

Conversation

sebastianbenz
Copy link
Collaborator

No description provided.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@sebastianbenz sebastianbenz merged commit 3df570b into master May 27, 2020
@sebastianbenz
Copy link
Collaborator Author

CLI has been signed if #798

@sebastianbenz sebastianbenz deleted the merceyz-missing-dependencies branch May 27, 2020 12:38
@merceyz
Copy link
Contributor

merceyz commented May 27, 2020

@sebastianbenz Seems you omitted cross-fetch, but it's also needed since it's used here

let fetch = require('cross-fetch');

@sebastianbenz
Copy link
Collaborator Author

@merceyz cross-fetch is a transitive dependency of toolbox-core

@merceyz
Copy link
Contributor

merceyz commented May 27, 2020

@sebastianbenz That makes us rely on hoisting which is really fragile and prone to breaking. If you want to require it from toolbox-core you should use createRequire or have toolbox-core export it.

Running npm i cross-fetch@1 @ampproject/toolbox-optimizer will produce a tree looking like this:

. -> cross-fetch@1
  -> core -> [email protected]
  -> optimizer

This breaks optimizer as it will be getting cross-fetch@1 instead of [email protected]

@sebastianbenz
Copy link
Collaborator Author

Thanks for the explanation. Will add it.

@merceyz
Copy link
Contributor

merceyz commented May 27, 2020

Awesome, thank you. Also, the same issue is present for toolbox-cli, it tries to use toolbox-core without declaring it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants