Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lts #781

Merged
merged 3 commits into from
May 20, 2020
Merged

Fix lts #781

merged 3 commits into from
May 20, 2020

Commits on May 15, 2020

  1. Fix LTS support 

    The new runtime parameter handling resulted in the LTS option no longer
working. Moving lts + ampRuntimeVersion in fetchRuntimeParameters.

This PR also improves logging and fixes a bug where the styles fallback
did not work.

Fixes #777
    @sebastianbenz
    sebastianbenz committed May 15, 2020
    Configuration menu
    Copy the full SHA
    276677a View commit details
    Browse the repository at this point in the history

  2. Improve error handling 

    Fallback to cdn.ampproject.org if custom runtime host cannot be
resolved
    @sebastianbenz
    sebastianbenz committed May 15, 2020
    Configuration menu
    Copy the full SHA
    7deecab View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. addressed comments

    @sebastianbenz
    sebastianbenz committed May 18, 2020
    Configuration menu
    Copy the full SHA
    61c4a66 View commit details
    Browse the repository at this point in the history