amp optimizer to support ampjs.org (not enabled as default) #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrozenberg
approved these changes
May 23, 2024
|
I think we would want to eventually change this so that it defaults to whatever CDN is used in the page being optimized, instead of defaulting to cdn.ampproject.org. wdyt? |
|
@danielrozenberg I made it so that we only need to flip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will enable the transformer to recognize ampjs.org as valid AMP CDN. However, it does not automatically change the CDN to ampjs.org. The default is still cdn.ampproject.org. To use ampjs.org, can override with
ampUrlPrefixparam.Adds test cases to ensure script tags pointing to either CDN get rewritten to the CDN configured.