Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Add icomoon #1149

Merged
merged 3 commits into from
Feb 26, 2021
Merged

🔧 Add icomoon #1149

merged 3 commits into from
Feb 26, 2021

Conversation

lluerich
Copy link
Collaborator

  • Add icons and icomoon font-family

@@ -32,7 +32,7 @@ const ICON_FONT_IDENTIFIERS = [
},
{
className: "icon-",
fontFamilies: ["icon"],
fontFamilies: ["icon", "icons", "icomoon"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case? Have we already got tests for all the icon font providers?

* obviously they only exist in svg format
* icofont
* icomoon
* nerd font
Copy link
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sebastianbenz sebastianbenz merged commit e2b8676 into ampproject:main Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants