Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a possibility to have custom dependencies in Custom Transformer #198

Open
06romix opened this issue May 14, 2021 · 0 comments
Open

Add a possibility to have custom dependencies in Custom Transformer #198

06romix opened this issue May 14, 2021 · 0 comments

Comments

@06romix
Copy link
Contributor

06romix commented May 14, 2021

What do you think about adding a possibility to have custom dependencies in Custom Transformer? We can allow passing the already created object of Transformer into configuration instead of the class name.

Developing the AMP plugin for Magento 2, I have to use a service similar to Psr\Container\ContainerInterface to support dependency inversion. And it would be nice to have an opportunity to use some libraries by adding them in transformers construct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants