Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set_group put group_type/group_name in groups attribute #28

Merged
merged 3 commits into from
Jun 22, 2022
Merged

fix: set_group put group_type/group_name in groups attribute #28

merged 3 commits into from
Jun 22, 2022

Conversation

bohan-amplitude
Copy link
Contributor

Summary

Put group_type and group_name in groups attributes of IdentifyEvent instead of user_properties.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@bohan-amplitude
fix set_group
a5df3d7 
Put group_type and group_name in groups attributes of IdentifyEvent instead of user_properties.
@bohan-amplitude
remove Final supported in 3.8
2691307
@bohan-amplitude
update set group test case
c9ff553
@bohan-amplitude bohan-amplitude merged commit 828040e into amplitude:main Jun 22, 2022
qingzhuozhen
qingzhuozhen reviewed Jun 23, 2022
View reviewed changes
Copy link
Contributor

@qingzhuozhen qingzhuozhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, will do this with Android later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingzhuozhen qingzhuozhen qingzhuozhen left review comments

@kevinpagtakhan kevinpagtakhan kevinpagtakhan approved these changes

@justin-fiedler justin-fiedler Awaiting requested review from justin-fiedler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bohan-amplitude @kevinpagtakhan @qingzhuozhen