fix: skip top domain when cookie is disabled

Author: liuyang1520

src/base-cookie.js

@@ -1,5 +1,4 @@
 import Constants from './constants';
-import base64Id from './base64Id';
 import utils from './utils';
 
 const get = (name) => {
@@ -94,7 +93,7 @@ const sortByEventTime = (cookies) => {
 
 // test that cookies are enabled - navigator.cookiesEnabled yields false positives in IE, need to test directly
 const areCookiesEnabled = (opts = {}) => {
-  const cookieName = Constants.COOKIE_TEST_PREFIX + base64Id();
+  const cookieName = Constants.COOKIE_TEST_PREFIX;
   if (typeof document === 'undefined') {
     return false;
   }

src/metadata-storage.js

@@ -36,7 +36,7 @@ class MetadataStorage {
 
     this.cookieDomain = '';
     const loc = getLocation() ? getLocation().href : undefined;
-    const writableTopDomain = topDomain(loc);
+    const writableTopDomain = !disableCookies ? topDomain(loc) : '';
     this.cookieDomain = domain || (writableTopDomain ? '.' + writableTopDomain : null);
 
     if (storageOptionExists[storage]) {

test/amplitude-client.js

@@ -2739,7 +2739,27 @@ describe('AmplitudeClient', function () {
       });
     });
 
-    it('should not create any cookies if disabledCookies = true', function () {
+    it('should not create any cookies with simple host if disabledCookies = true', function () {
+      deleteAllCookies();
+      clock.tick(20);
+
+      var cookieArray = getAllCookies();
+      assert.equal(cookieArray.length, 0);
+
+      var deviceId = 'test_device_id';
+      var amplitude2 = new AmplitudeClient();
+
+      amplitude2.init(apiKey, null, {
+        deviceId: deviceId,
+        disableCookies: true,
+      });
+
+      cookieArray = getAllCookies();
+      assert.equal(cookieArray.length, 0);
+    });
+
+    it('should not create any cookies with multiple domains in host if disabledCookies = true', function () {
+      window.href = 'https://abc.def.xyz/test';
       deleteAllCookies();
       clock.tick(20);