-
-
Notifications
You must be signed in to change notification settings - Fork 9
Add session page for Martin #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| --- | ||
| title: 'A F# Compiler Tour: Reviewing "Scoped Nowarn"' | ||
| preview: 'A F# Compiler Tour: Reviewing "Scoped Nowarn"' | ||
| isDraft: true | ||
| date: 2024-12-13T14:00:00.000Z | ||
| slug: "2024/11/22" | ||
| champion: "Martin" | ||
| zoomLink: "https://us06web.zoom.us/j/86109507433?pwd=qc6GJtAjXynXVBUE7puI4RwcbOQBI4.1" | ||
| zoomPasscode: "review" | ||
| youtubeId: "" | ||
| --- | ||
|
|
||
| ## Topic | ||
|
|
||
| The F\# language is driven by language suggestions in . | ||
| Placing a suggestion is easy, the hardship is listed in the implementation. | ||
| As we established in some of our past [sessions](../) contributing to the F\# compiler can be challeging. | ||
| And even we you managed to make it work, in open-source, you still need a signoff from the maintainers. | ||
|
|
||
| In this session, we will take [dotnet/fsharp/#18049](https://github.com/dotnet/fsharp/pull/18049) as a case study on how a language suggestion was implemented. | ||
| We will try and have a mob PR review session to provide feedback on this large pull request. | ||
|
|
||
| The evolution of the F# language is guided by community suggestions submitted to the [fsharp/fslang-suggestions](https://github.com/fsharp/fslang-suggestions) repository. While proposing a new idea is straightforward, the real challenge often lies in its implementation. As we’ve discussed in previous [sessions](../../), contributing to the F# compiler can be demanding. Even after overcoming the technical hurdles, open-source contributions require approval from maintainers to be accepted. | ||
|
|
||
| In this session, we’ll examine [dotnet/fsharp/#18049](https://github.com/dotnet/fsharp/pull/18049) as a case study, exploring how a language suggestion made its way to implementation. Additionally, we’ll conduct a mob PR review to provide collaborative feedback on this substantial pull request. | ||
|
|
||
| ## Champion | ||
|
|
||
| - [Martin](https://github.com/Martin521) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.