-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favicon with hash #364
Comments
Hm don't know why but you could use the https://github.com/jantimon/favicons-webpack-plugin - it will generate a hashed filename if needed. |
Why was this issue closed? The error still persists. |
Is there any update on this? |
I think it's important to note that even if the hash did work for favicon, it is a compilation hash and not a content hash. The hash is also appended via query string as opposed to appending to the file name. Neither of these qualities are ideal for caching so I suggest users either create a PR fix or find an alterntative solution (that's what I'm doing). This library has been great for generating the html and I'm going to leave its purpose at that. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
https://github.com/ampedandwired/html-webpack-plugin/blob/master/index.js#L410
Says that with option
hash: true
, It would add a hash to favicons. After several tests, I realized that javascript and css files contains a hash, but favicons don't. Maybe is this a bug?My config:
The text was updated successfully, but these errors were encountered: