Back out "feat: Add support for evaluating Iceberg partition transforms" (facebookincubator#15475)

Summary:

Original commit changeset: ae45744c1ae1

Original Phabricator Diff: D86686271

details: prestodb/presto#26584 (comment)

Reviewed By: abhash09

Differential Revision: D86821554

Author: amitkdutta

velox/connectors/hive/HiveConnector.cpp

@@ -21,7 +21,6 @@
 #include "velox/connectors/hive/HiveDataSource.h"
 #include "velox/connectors/hive/HivePartitionFunction.h"
 #include "velox/connectors/hive/iceberg/IcebergDataSink.h"
-#include "velox/functions/iceberg/Register.h"
 
 #include <boost/lexical_cast.hpp>
 #include <memory>
@@ -43,7 +42,6 @@ HiveConnector::HiveConnector(
               : nullptr,
           std::make_unique<FileHandleGenerator>(hiveConfig_->config())),
       ioExecutor_(ioExecutor) {
-  iceberg::registerIcebergFunctions();
   if (hiveConfig_->isFileHandleCacheEnabled()) {
     LOG(INFO) << "Hive connector " << connectorId()
               << " created with maximum of "

velox/connectors/hive/iceberg/CMakeLists.txt

@@ -20,15 +20,6 @@ velox_add_library(
   IcebergSplitReader.cpp
   PartitionSpec.cpp
   PositionalDeleteFileReader.cpp
-  TransformEvaluator.cpp
-  TransformExprBuilder.cpp
-)
-
-velox_link_libraries(
-  velox_hive_iceberg_splitreader
-  velox_connector
-  velox_functions_iceberg
-  Folly::folly
 )
 
 velox_link_libraries(velox_hive_iceberg_splitreader velox_connector Folly::folly)

velox/connectors/hive/iceberg/PartitionSpec.cpp

@@ -16,7 +16,6 @@
 
 #include "velox/connectors/hive/iceberg/PartitionSpec.h"
 
-#include "velox/functions/iceberg/Register.h"
 #include "velox/functions/prestosql/types/TimestampWithTimeZoneType.h"
 
 namespace facebook::velox::connector::hive::iceberg {
@@ -103,14 +102,6 @@ VELOX_DEFINE_ENUM_NAME(TransformType, transformTypeNames);
 
 VELOX_DEFINE_ENUM_NAME(TransformCategory, transformCategoryNames);
 
-void registerIcebergFunctions() {
-  static std::once_flag registerFlag;
-
-  std::call_once(registerFlag, []() {
-    functions::iceberg::registerFunctions(kIcebergFunctionPrefix);
-  });
-}
-
 void IcebergPartitionSpec::checkCompatibility() const {
   folly::F14FastMap<std::string_view, std::vector<TransformType>>
       columnTransforms;

velox/connectors/hive/iceberg/PartitionSpec.h

@@ -20,25 +20,6 @@
 
 namespace facebook::velox::connector::hive::iceberg {
 
-inline constexpr char const* kIcebergFunctionPrefix{"iceberg_"};
-
-inline const std::string kBucketFunction =
-    std::string(kIcebergFunctionPrefix) + "bucket";
-inline const std::string kTruncateFunction =
-    std::string(kIcebergFunctionPrefix) + "truncate";
-inline const std::string kYearFunction =
-    std::string(kIcebergFunctionPrefix) + "years";
-inline const std::string kMonthFunction =
-    std::string(kIcebergFunctionPrefix) + "months";
-inline const std::string kDayFunction =
-    std::string(kIcebergFunctionPrefix) + "days";
-inline const std::string kHourFunction =
-    std::string(kIcebergFunctionPrefix) + "hours";
-
-/// Registers Iceberg partition transform functions with prefix
-/// kIcebergFunctionPrefix.
-void registerIcebergFunctions();
-
 /// Partition transform types.
 /// Defines how source column values are converted into partition keys.
 /// See https://iceberg.apache.org/spec/#partition-transforms.
@@ -132,7 +113,6 @@ struct IcebergPartitionSpec {
         case TransformType::kTruncate:
           return type;
       }
-      VELOX_UNREACHABLE("Unknown transform type");
     }
   };
 

velox/connectors/hive/iceberg/TransformEvaluator.cpp

@@ -64,7 +64,6 @@ if(NOT VELOX_DISABLE_GOOGLETEST)
     IcebergTestBase.cpp
     Main.cpp
     PartitionSpecTest.cpp
-    TransformTest.cpp
   )
 
   add_test(velox_hive_iceberg_insert_test velox_hive_iceberg_insert_test)