Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kwik.ipynb Code issue: missing case in determine and learn #2

Open
zbiswas3 opened this issue Jul 4, 2019 · 0 comments
Open

kwik.ipynb Code issue: missing case in determine and learn #2

zbiswas3 opened this issue Jul 4, 2019 · 0 comments

Comments

@zbiswas3
Copy link

zbiswas3 commented Jul 4, 2019

So In _determine_and_learn function basically covers two cases: one for return 0 and one for return -1 but there is no case for returning 1. For example, if atEstablishment there is no patron from the peacemakers but all the possible instigator is present, that should return 1. I don't see that case.

Also, the section where you mentioned TODO: this is not right about instigator, I think adding a conditional statement would fix it. For example, I rewrite the code using this logic: if fightoccured --> if patron present then he is not a peacemaker and if he is not present, then he is not the instigator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant