You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So In _determine_and_learn function basically covers two cases: one for return 0 and one for return -1 but there is no case for returning 1. For example, if atEstablishment there is no patron from the peacemakers but all the possible instigator is present, that should return 1. I don't see that case.
Also, the section where you mentioned TODO: this is not right about instigator, I think adding a conditional statement would fix it. For example, I rewrite the code using this logic: if fightoccured --> if patron present then he is not a peacemaker and if he is not present, then he is not the instigator.
The text was updated successfully, but these errors were encountered:
So In _determine_and_learn function basically covers two cases: one for return 0 and one for return -1 but there is no case for returning 1. For example, if atEstablishment there is no patron from the peacemakers but all the possible instigator is present, that should return 1. I don't see that case.
Also, the section where you mentioned TODO: this is not right about instigator, I think adding a conditional statement would fix it. For example, I rewrite the code using this logic: if fightoccured --> if patron present then he is not a peacemaker and if he is not present, then he is not the instigator.
The text was updated successfully, but these errors were encountered: