Skip to content

The Address Sanitizer check for MSVC is inverted #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ddassie-texa opened this issue Jun 17, 2024 · 0 comments · Fixed by #266
Closed

The Address Sanitizer check for MSVC is inverted #265

ddassie-texa opened this issue Jun 17, 2024 · 0 comments · Fixed by #266

Comments

@ddassie-texa
Copy link
Contributor

ddassie-texa commented Jun 17, 2024

I noticed that with the latest main branch Address Sanitizer is no longer enabled by default for MSVC, looking at the code, the detection in check_sanitizers_support is inverted:

if("${index_of_vs_install_dir}" STREQUAL "-1")

it should be:

if(NOT "${index_of_vs_install_dir}" STREQUAL "-1")

You can see the check is inverted if you check the detection logic in

if("${index_of_vs_install_dir}" STREQUAL "-1")

@ddassie-texa ddassie-texa changed the title The Address Sanitizer check ofr MSVC is inverted The Address Sanitizer check for MSVC is inverted Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant