-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BT.709 for PAL SD #862
Comments
According to ITU-T H.273, if I understand well, all BT.470 systems are marked as "historical" and superseded by BT.601 for SD. In FFmpeg, if we want all fields to reflect PAL BT.601, we can use:
It is functionally the same as the parameters currently implemented in vrecord, but maybe it is semantically more accurate. |
Hi @etienne-ina, with those options and using ffmpeg 7.1, the colr atom in a quicktime recording would look like:
Apple's QuickTime documentation calls these: Although, that output seems the same as before, so making the proposed change wouldn't change the QuickTime output. @etienne-ina @stubhead (cc @JeromeMartinez), could you clarify which index values in particular you'd propose for the QuickTime colr atom. See https://developer.apple.com/documentation/quicktime-file-format/color_parameter_atom or possibly the ISOBMFF might have this more recently documented. |
Well, if those values are unknown by Apple, that's an issue indeed, but only in a QuickTime file, right? |
Hi @dericed , Thanks to stubhead, we found out that there actually was a bug in ffmpeg v7.1 regarding the color_primaries and color_trc parameters. |
Hi @etienne-ina, I had forgotten in this testing that vrecord uses ffmpeg 5.1.4 specifically, via this formula https://github.com/amiaopensource/homebrew-amiaos/blob/master/ffmpegdecklink.rb. So this should be retested in that version. If you have vrecord installed you can access that ffmpeg via |
I'm not actually using vrecord, but we were trying to align our FFV1 encoding settings to what is proposed by vrecord as a reference tool, hence the question about color parameters. |
This is a question regarding color transfer characteristics in encoding to FFV1.
Research for vrecord saw BT709 implemented for all FFV1 capture:
vrecord/vrecord
Lines 881 to 895 in 50e9dba
Dave Rice comments :
"[these comments] came from this section of vrecord which sets color metadata for SD captures in vrecord, conditionally, whether they are NTSC or PAL: https://github.com/amiaopensource/vrecord/blob/main/vrecord#L1873-L1894."
...and further :
"In the QuickTime specs at https://developer.apple.com/documentation/quicktime-file-format/color_parameter_atom, in the transfer index the transfer function value 5 is reserved. But now transfer function = 5 is regarded at bt 470 b/g. Also at the time, we were trying to get vrecord to emulate Final Cut Pro and I believe it used the same transfer function = 1 value which used the same values as bt709."
For encoding from PAL SD, which is the better choice? BT.709 or BT.470 B/G ?
The text was updated successfully, but these errors were encountered: