Skip to content

Commit 1641f14

Browse files
author
Adam Gleitman
committed
Address PR comments
1 parent a4c03ca commit 1641f14

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

packages/react-native/React/Views/RCTView.m

+1-1
Original file line numberDiff line numberDiff line change
@@ -1319,7 +1319,7 @@ - (void)displayLayer:(CALayer *)layer
13191319
}
13201320

13211321
#if TARGET_OS_OSX // [macOS
1322-
- (void)updateInternalReactTransform:(CATransform3D)transform
1322+
- (void)updateReactTransformInternal:(CATransform3D)transform
13231323
{
13241324
[self setTransform3D:transform];
13251325
[self setNeedsDisplay];

packages/react-native/React/Views/UIView+React.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,9 @@ typedef struct {
8686

8787
#if TARGET_OS_OSX // [macOS
8888
/**
89-
* Used by react-native-macos to propagate transform changes internally.
89+
* Used by macOS to propagate transform changes internally.
9090
*/
91-
- (void)updateInternalReactTransform:(CATransform3D)transform;
91+
- (void)updateReactTransformInternal:(CATransform3D)transform;
9292
#endif // macOS]
9393

9494
/**

packages/react-native/React/Views/UIView+React.m

+3-3
Original file line numberDiff line numberDiff line change
@@ -311,14 +311,14 @@ static void updateTransform(RCTPlatformView *view) // [macOS]
311311
// Enable edge antialiasing in rotation, skew, or perspective transforms
312312
view.layer.allowsEdgeAntialiasing = transform.m12 != 0.0f || transform.m21 != 0.0f || transform.m34 != 0.0f;
313313
#else // [macOS
314-
[view updateInternalReactTransform:transform];
314+
[view updateReactTransformInternal:transform];
315315
#endif // macOS]
316316
}
317317

318318
#if TARGET_OS_OSX // [macOS
319-
- (void)updateInternalReactTransform:(CATransform3D)transform
319+
- (void)updateReactTransformInternal:(CATransform3D)transform
320320
{
321-
// Do nothing, this will get overridden by RCTView
321+
// Do nothing, this will get overridden by RCTView and other subclasses as needed.
322322
}
323323
#endif // macOS]
324324

0 commit comments

Comments
 (0)