This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
feat(metrics): add module rejection and fallback gauges #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 710 kB ℹ️ View Unchanged
|
dogpatch626
reviewed
Sep 14, 2023
Co-authored-by: Matthew Mallimo <[email protected]>
Matthew-Mallimo
previously approved these changes
Sep 14, 2023
PixnBits
suggested changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
three nitpicks, but one blocker(?) suggestion
Co-authored-by: Nick Oliver <[email protected]>
10xLaCroixDrinker
approved these changes
Sep 21, 2023
Matthew-Mallimo
approved these changes
Sep 22, 2023
PixnBits
approved these changes
Sep 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added two additional holocron gauges.
Motivation and Context
Provide a high level metrics to indicate to users how unhealthy the state of their module map is.
Information on rejected modules and modules using externals information is already logged so this feature does not provide insight where there was none but exposes it in a different light.
How Has This Been Tested?
Locally started one-app with both modules which would be rejected and ones which load but required external fallbacks.
Types of Changes
Checklist:
What is the Impact to Developers Using One App?