Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(metrics): add module rejection and fallback gauges #1131

Merged
merged 8 commits into from
Sep 22, 2023

Conversation

JAdshead
Copy link
Contributor

@JAdshead JAdshead commented Sep 13, 2023

Description

added two additional holocron gauges.

  1. to track the total number of rejected modules after each module map update.
  2. to track the total number of modules which are using fallback externals.

Motivation and Context

Provide a high level metrics to indicate to users how unhealthy the state of their module map is.
Information on rejected modules and modules using externals information is already logged so this feature does not provide insight where there was none but exposes it in a different light.

How Has This Been Tested?

Locally started one-app with both modules which would be rejected and ones which load but required external fallbacks.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@JAdshead JAdshead marked this pull request as ready for review September 13, 2023 19:30
@JAdshead JAdshead requested review from a team as code owners September 13, 2023 19:30
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

Size Change: 0 B

Total Size: 710 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 164 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 121 kB

compressed-size-action

Co-authored-by: Matthew Mallimo <[email protected]>
@JAdshead JAdshead requested a review from a team September 14, 2023 19:40
Copy link
Contributor

@PixnBits PixnBits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

three nitpicks, but one blocker(?) suggestion

src/server/metrics/holocron.js Outdated Show resolved Hide resolved
src/server/metrics/holocron.js Outdated Show resolved Hide resolved
__tests__/server/utils/pollModuleMap.spec.js Show resolved Hide resolved
__tests__/server/utils/pollModuleMap.spec.js Outdated Show resolved Hide resolved
@PixnBits PixnBits enabled auto-merge (squash) September 22, 2023 18:23
@PixnBits PixnBits merged commit b60895a into main Sep 22, 2023
@PixnBits PixnBits deleted the feat/track-modules-using-fallback branch September 22, 2023 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants