Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

fix(cache-modules): stringify object #51

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix(cache-modules): stringify object #51

merged 2 commits into from
Sep 28, 2023

Conversation

bishnubista
Copy link
Contributor

Fixed issue where setUp was stringfied as object
JSON.stringify('{}') --> JSON.stringify({})

Description

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • This change adds additional environment variable requirements for one-app-dev-cdn users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using one-app-dev-cdn?

@bishnubista bishnubista requested review from a team as code owners September 28, 2023 18:32
JAdshead
JAdshead suggested changes Sep 28, 2023
View reviewed changes
src/util/index.js Show resolved Hide resolved
@JAdshead JAdshead requested a review from a team September 28, 2023 19:41
@Matthew-Mallimo Matthew-Mallimo merged commit fd2cb78 into main Sep 28, 2023
@Matthew-Mallimo Matthew-Mallimo deleted the fix/dev-cdn-intialize branch September 28, 2023 19:58
oneamexbot added a commit that referenced this pull request Sep 28, 2023
@oneamexbot
chore(release): 3.4.1 [skip ci]
02e8c50 
## [3.4.1](v3.4.0...v3.4.1) (2023-09-28)

### Bug Fixes

* **cache-modules:** stringify object ([#51](#51)) ([fd2cb78](fd2cb78))
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 3.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Matthew-Mallimo Matthew-Mallimo Matthew-Mallimo approved these changes

@JAdshead JAdshead JAdshead approved these changes

Assignees
No one assigned
Labels
one-app-team-review-requested released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bishnubista @oneamexbot @JAdshead @Matthew-Mallimo