Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry on NetworkingError by default #20

Open
amekkawi opened this issue Oct 9, 2017 · 0 comments
Open

Retry on NetworkingError by default #20

amekkawi opened this issue Oct 9, 2017 · 0 comments
Assignees
@amekkawi
Labels
enhancement

Comments

@amekkawi
Copy link
Owner

amekkawi commented Oct 9, 2017 •
edited
Loading

Acceptance criteria

  • CWLogsWritable#retryOnNetworkingError property that defaults to true.
  • CWLogsWritable constructor options support an optional retryOnNetworkingError property that will set to CWLogsWritable#retryOnNetworkingError if it is === false.
  • [TBD] CWLogsWritable ignores errors that have a name property that equals "NetworkingError" and CWLogsWritable#retryOnNetworkingError is true. This bypasses the onError call, and acts the same as calling its next argument as next(); (or next(logEvents); if logEvents was passed).
@amekkawi amekkawi self-assigned this Oct 9, 2017
@amekkawi amekkawi changed the title Retry on NetworkingError Retry on NetworkingError by default Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amekkawi amekkawi

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amekkawi