Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine calculation of Code Refactoring Ratio to handle ratios under 1.0 #1

Open
amclin opened this issue Aug 23, 2018 · 0 comments
Open
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@amclin
Copy link
Owner

amclin commented Aug 23, 2018

The calculations of Code Refactoring Ratio needs to be revised because it is non-continugous:

  1. A ratio of undefined would be considered good ( code changes divided by 0 test changes)
  2. A ratio of < 1 would be considered bad (more test changes than code changes), and the close to 0 that it gets, the worse it is
  3. Ratios above 1.0 increase positively as the value increases

https://github.com/amclin/devopsculture/blob/master/_kpis/code-refactoring.md#todo-future-refinement

With these definitions, a Refactoring Ratio of undefined is ideal (lots of code changes, with no test changes). But a fractional Refactoring Ratio value between 0 and 1 is bad as it indicates code changes require significantly more testing.

@amclin amclin added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers bug Something isn't working labels Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant