-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email notification settings #489
Comments
@vickywane this is the corresponding backend implementation running on edge deployments: ambianic/ambianic-edge#50 |
The case was made for supporting multiple email addresses for notification alerts.
|
@vickywane as you are exploring implementation options for email notifications, there is another possibility to consider. We could potentially use the recently introduced github sponsors API to obtain an OAuth token from the PWA. Then if the user is a sponsor, we can use that token in the edge to call into a new ephemeral serverless function, let's call it AmbianicNotificationsProxy, which proxies notification calls from the edge to notification service providers such as mailgun, ifttt, AWS SMS, etc. AmbianicNotificationsProxy can verify calls against valid ambiniac github sponsor tokens and then use deployment environment secret variables to route messages from the edge to mailgun and other notification services in the future. It won't need a database to store any data of its own. I just tested the new github sponsors GraphQL and it seems to work fine. See links and screenshots. This will mean that only sponsoring users can use the new notifications feature, but I think that's a reasonable value for a few dollars per month. Users who don't want to be sponsoring us, can still use notifications by editing config.yaml on the edge with the service provider credentials of their choice. Thoughts? |
Are all Ambianic users Github sponsors? |
No. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Addressed via #773 |
Is your feature request related to a problem? Please describe.
Currently notification settings have to be provided in the edge device config.yaml.
Describe the solution you'd like
End users need a easy way to configure notification preferences via the UI app.
Describe alternatives you've considered
Using config.yaml is OK for developers, but not end users.
Additional context
The UI has to offer a way for users to provide email address where edge notifications will be sent to.
Respectively the UI needs to update the edge configuration via its config REST API when user's preferences change.
The UI notification settings design would ideally take into account future improvements that allow multiple notification targets - iftt, push notifications, SMS , etc.
The text was updated successfully, but these errors were encountered: