Skip to content

Commit 6251b10

Browse files
fix: Added spaces and missing step
Added steps in deploy job. Added some spaces to easier see each job.
1 parent 33278c0 commit 6251b10

File tree

1 file changed

+24
-20
lines changed

1 file changed

+24
-20
lines changed

Diff for: .github/workflows/nodejs.yml

+24-20
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ jobs:
4141
env:
4242
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
4343
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
44+
4445
- name: Code Coverage Report
4546
uses: codecov/codecov-action@v1
4647
with:
@@ -53,24 +54,27 @@ jobs:
5354
deploy:
5455
runs-on: ubuntu-latest
5556
needs: test
56-
- name: Build PWA distribution for production
57-
run: |
58-
npm run build --if-present
59-
env:
60-
CI: true
61-
- name: Run Lighthouse PWA check against local production build
62-
uses: treosh/lighthouse-ci-action@v2
63-
with:
64-
# no urls needed, since it uses local folder to scan .html files
65-
# budgetPath: '.github/lighthouse/budget.json' # performance budgets
66-
configPath: '.github/lighthouse/lighthouserc-static-dist-dir.yml'
67-
uploadArtifacts: true # save results as an action artifacts
68-
temporaryPublicStorage: true # upload lighthouse report to the temporary storage
69-
- name: Semantic Release
70-
if: github.event_name == 'push'
71-
run: npx semantic-release
72-
env:
73-
GITHUB_TOKEN: ${{ secrets.GITHUB_PAT }}
74-
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
75-
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
57+
steps:
58+
- name: Build PWA distribution for production
59+
run: |
60+
npm run build --if-present
61+
env:
62+
CI: true
63+
64+
- name: Run Lighthouse PWA check against local production build
65+
uses: treosh/lighthouse-ci-action@v2
66+
with:
67+
# no urls needed, since it uses local folder to scan .html files
68+
# budgetPath: '.github/lighthouse/budget.json' # performance budgets
69+
configPath: '.github/lighthouse/lighthouserc-static-dist-dir.yml'
70+
uploadArtifacts: true # save results as an action artifacts
71+
temporaryPublicStorage: true # upload lighthouse report to the temporary storage
72+
73+
- name: Semantic Release
74+
if: github.event_name == 'push'
75+
run: npx semantic-release
76+
env:
77+
GITHUB_TOKEN: ${{ secrets.GITHUB_PAT }}
78+
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
79+
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
7680

0 commit comments

Comments
 (0)