Skip to content

Commit 1783063

Browse files
committed
fix: organize lighthouse CI for localhost and deployed versions
1 parent a7ff7f3 commit 1783063

File tree

1 file changed

+18
-19
lines changed

1 file changed

+18
-19
lines changed

Diff for: .github/workflows/lighthouse.yml

+18-19
Original file line numberDiff line numberDiff line change
@@ -35,29 +35,28 @@ jobs:
3535
with:
3636
site_name: "happy-franklin-69b6d4"
3737

38-
# lighthouse local test
38+
# lighthouse localhost test
3939
- name: Lighthouse CI
4040
run: |
4141
npm install -g @lhci/[email protected]
4242
lhci autorun --config=.github/lighthouse/lighthouserc.json
43-
lhci autorun --config=.github/lighthouse/lighthouserc.json --upload.target=temporary-public-storage --collect.url=${{ steps.waitFor200.outputs.url }} || echo "LHCI failed!"
4443
env:
4544
LHCI_GITHUB_APP_TOKEN: ${{ secrets.LHCI_GITHUB_APP_TOKEN }}
4645

47-
#runs the lighthouse action
48-
# - name: Lighthouse CI Action
49-
# uses: treosh/lighthouse-ci-action@v2
50-
# with:
51-
# urls: |
52-
# $DEPLOY_URL
53-
# budgetPath: '.github/lighthouse/budget.json' # test performance budgets
54-
# configPath: '.github/lighthouse/lighthouserc.json'
55-
# # Path to a LHCI lighthouserc.json file
56-
# # Opt-out of saving Lighthouse results as an action artifacts
57-
# uploadArtifacts: false
58-
# # Number of runs to do per URL
59-
# serverBaseUrl: ${{ secrets.LHCI_SERVER_URL }}
60-
# serverToken: ${{ secrets.LHCI_SERVER_TOKEN }}
61-
# env:
62-
# DEPLOY_URL: ${{ steps.waitFor200.outputs.url }}
63-
46+
# runs the lighthouse action (deployed)
47+
- name: Lighthouse CI Action
48+
uses: treosh/lighthouse-ci-action@v2
49+
with:
50+
urls: |
51+
$DEPLOY_URL
52+
budgetPath: '.github/lighthouse/budget.json' # test performance budgets
53+
configPath: '.github/lighthouse/lighthouserc.json'
54+
# Path to a LHCI lighthouserc.json file
55+
# Opt-out of saving Lighthouse results as an action artifacts
56+
uploadArtifacts: false
57+
# Number of runs to do per URL
58+
serverBaseUrl: ${{ secrets.LHCI_SERVER_URL }}
59+
serverToken: ${{ secrets.LHCI_SERVER_TOKEN }}
60+
env:
61+
DEPLOY_URL: ${{ steps.waitFor200.outputs.url }}
62+

0 commit comments

Comments
 (0)