Consider CLI config parameters in HTTP request checks #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switch to derive-based parsing of CLI parameters - bump up 'clap' to '3.0.0-beta.2' version - make CLI config accessible globally
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #756
Propagates CLI config params as fallback for POST HTTP request params, instead of falling back to default hardcoded values.
Also, this PR makes a brave attempt to reorganize CLI declaration and parsing using derive macros approach instead YAML, and makes the config globally accessible, which is handy/suitable enough for such a tiny CLI application, while removes a redundant friction with lifetimes/cloning in Hyper server.