You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wow, thank you @casperisfine! I'm glad that you liked this.
I skimmed the code quickly, but didn't notice anything that couldn't really be upstreamed. Is there something I missed?
I know that you're too clever that you could skim through this pile of dark matter quickly. But... I confess that I'm already unable to quickly skim this thing that I wrote last year... I mean, the reason why I didn't upstream this is that I just don't want to see such a hack in the Rails codebase.
I see no disadvantage at routes being lazy in development.
Yeah, this is true, in most cases. I thought so too when I started this project, and so the whole patch was a lot more simple and readable, but we found that the real-world apps have exceptions such as rails routes task and workers that render some views (and maybe more), then this monkey-patch collection became bigger and bigger. If we're upstreaming this, maybe we can add a flag to Rails.config that is enabled only for development / test, and with that the patch could be written much simpler. Also, I don't like the current Rack Middleware approach. There should be a better solution than adding a Middleware stack here, but I just chose an easy way that worked.
👋 I was looking for ways to speed up boot time in my application recently and stumbled across this gem. I wrote a patch with the same idea, but a slightly different implementation here: rails/rails#51614. If it gets merged, this gem may no longer be needed.
I skimmed the code quickly, but didn't notice anything that couldn't really be upstreamed. Is there something I missed?
I see no disadvantage at routes being lazy in development.
The text was updated successfully, but these errors were encountered: