Use Internet Explorer conditional comment syntax to preserve morph markers on Cloudflare-proxied sites #3794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkers on Cloudflare-proxied sites
Collaborator
|
Great! Thank you Mark! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the morph markers that Alpine recognizes to match the ones in this Livewire PR: livewire/livewire#6974
<!--[if BLOCK]><![endif]--><!--[if ENDBLOCK]><![endif]-->Read that PR for more details, but basically the issue is that some proxies strip HTML comments, which means that the morph markers that a backend like Livewire renders might get stripped by things like Cloudflare (with HTML minification on). The Internet Explorer conditional syntax above will be ignored by Cloudflare (and likely other HTML-minification pipelines) because historically it was used to enable or disable functionality on certain browsers.